[PATCH 1/2] drm: exynos: Use DRM_FORMAT_{NV12, YUV420} instead of DRM_FORMAT_{NV12M, YUV420M}

[InKi Dae]

thanks for your patch but your patch set needs some codes for
identifying whether pixel format is multiplanar or not as you
mentioned. so I will add the codes and apply your patch set to
exynos-drm-fixes branch for drm-fixes.


2012년 4월 21일 오전 12:26,  <ville.syrjala at linux.intel.com>님의 말:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> The NV12M/YUV420M formats are identical to the already existing standard
> NV12/YUV420 formats. The M variants will be removed, so convert the
> driver to use the standard names.
>
> Cc: Inki Dae <inki.dae at samsung.com>
> Cc: Joonyoung Shim <jy0922.shim at samsung.com>
> Cc: Seung-Woo Kim <sw0312.kim at samsung.com>
> Cc: Kyungmin Park <kyungmin.park at samsung.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> Extra note: Based on a quick look, the driver appears to lack
> sufficient sanity checks wrt. the framebuffer layout. I guess it
> just assumes that handles[0] != handles[1] and offsets[] = { 0 }.
>
>  drivers/gpu/drm/exynos/exynos_drm_fb.h |    4 ++--
>  drivers/gpu/drm/exynos/exynos_mixer.c  |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.h b/drivers/gpu/drm/exynos/exynos_drm_fb.h
> index 3ecb30d..5082375 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.h
> @@ -31,10 +31,10 @@
>  static inline int exynos_drm_format_num_buffers(uint32_t format)
>  {
>        switch (format) {
> -       case DRM_FORMAT_NV12M:
> +       case DRM_FORMAT_NV12:
>        case DRM_FORMAT_NV12MT:
>                return 2;
> -       case DRM_FORMAT_YUV420M:
> +       case DRM_FORMAT_YUV420:
>                return 3;
>        default:
>                return 1;
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 4d5f41e..f1e2369 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -370,7 +370,7 @@ static void vp_video_buffer(struct mixer_context *ctx, int win)
>        switch (win_data->pixel_format) {
>        case DRM_FORMAT_NV12MT:
>                tiled_mode = true;
> -       case DRM_FORMAT_NV12M:
> +       case DRM_FORMAT_NV12:
>                crcb_mode = false;
>                buf_num = 2;
>                break;
> --
> 1.7.3.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel