[Nouveau] [PATCH 2/5] drm/nouveau: base fence timeout on time of emission
marcin.slusarz at gmail.com
Tue Apr 24 11:34:45 PDT 2012
On Tue, Apr 24, 2012 at 12:37:34PM +1000, Ben Skeggs wrote:
> On Mon, 2012-04-23 at 00:18 +0200, Marcin Slusarz wrote:
> > Wait loop can be interrupted by signal, so if signals are raised
> > periodically (e.g. SIGALRM) this loop may never finish. Use
> > emission time as a base for fence timeout.
> Ah, thanks for tackling this issue. It's been long on my list of things
> to do, but never quite made it to the top.
> Rather than hardcoding the timeout in fence_wait(), I think perhaps
> storing "fence->timeout = jiffies + (whatever * HZ);" is a better plan.
> I can forsee us wanting longer timeouts for certain operations
> (particularly long compute operations) in the future.
Yeah, good idea. Later, we will probably need to add code which will keep extending
this timeout as long as gpu is progressing.
More information about the dri-devel