[PATCH 06/26] drm/radeon: fix a critical bug in the SA code

Christian König deathsimple at vodafone.de
Wed Apr 25 06:36:03 PDT 2012


On 25.04.2012 15:19, Michel Dänzer wrote:
> On Mit, 2012-04-25 at 14:46 +0200, Christian König wrote:
>> Aligning offset can make it bigger than tmp->offset
>> leading to an overrun bug in the following subtraction.
>>
>> Signed-off-by: Christian König<deathsimple at vodafone.de>
> Please add
>
> Cc: stable at vger.kernel.org
>
> to the commit log (but don't send the patch to that address during
> review). That way, once Linus merges the fix, it'll be picked up for the
> 3.3.y stable tree.
>
> With that addition,
>
> Reviewed-by: Michel Dänzer<michel.daenzer at amd.com>
>
>
I don't think that's necessary, cause I checked the vm code again and 
Jerome has given it a separate instance of the SA.

So the bug can't happen in the stable kernel, it just happens when you 
add another user (the semaphore code) to the SA.

Over all it's not so critical as I thought it is in the first place and 
we need to keep digging for VM problems in other places.

Thanks for the explanation anyway,
Christian.


More information about the dri-devel mailing list