[PATCH 1/3] Replace i2f() in r600_blit.c with an optimized version.

Paul Menzel paulepanter at users.sourceforge.net
Mon Aug 6 14:42:12 PDT 2012


Dear Steven,


thank you for your patches.

Am Montag, den 06.08.2012, 11:14 -0700 schrieb Steven Fuerst:
> Replace i2f() in r600_blit.c with an optimized version.
> 
> We use __fls() to find the most significant bit.  Using that, the
> loop can be avoided.  A second trick is to use the mod(32)
> behaviour of the rotate instructions on x86 to expand the range
> of the unsigned int to float conversion to the full 32 bits.
> 
> The routine is now exact up to 2^24.  Above that, we truncate which
> is equivalent to rounding towards zero.
> 
> Signed-off-by: Steven Fuerst <svfuerst at gmail.com>
> ---
>  drivers/gpu/drm/radeon/r600_blit.c |   52
> +++++++++++++++++++++---------------

Unfortunately you sent your message not just as plain text [1] and the
Google Mail mailer automatically wrapped the lines and there mangled the
patch.

Please use a “good” mail client or just `git sent-email`. The manual
page has a section explaining how to set it up with Google Mail I think.
It would be great if you could resent your patches as `[PATCH][RESENT]`
(option `--subject-prefix=…` of `git format-patch`) since there is no
functional change.

[…]


Thanks,

Paul


[1] http://en.opensuse.org/openSUSE:Mailing_list_netiquette
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20120806/3997abee/attachment.pgp>


More information about the dri-devel mailing list