[PATCH] drm/usb: select USB_SUPPORT in Kconfig

[Sachin Kamat]

On 10 August 2012 19:35, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> On Fri, Aug 10, 2012 at 11:00:25AM +0530, Sachin Kamat wrote:
>> DRM_USB selects USB. However, USB depends on USB_SUPPORT and USB_ARCH_HAS_HCD.
>> Thus, selecting USB_SUPPORT in Kconfig avoids the following warning
>> (detected when DisplayLink was selected using exynos4_defconfig):
>>
>> warning: (MOUSE_APPLETOUCH && MOUSE_BCM5974 && MOUSE_SYNAPTICS_USB && JOYSTICK_XPAD && TABLET_USB_ACECAD && TABLET_USB_AIPTEK && TABLET_USB_HANWANG && TABLET_USB_KBTAB && TABLET_USB_WACOM && TOUCHSCREEN_USB_COMPOSITE && INPUT_ATI_REMOTE2 && INPUT_KEYSPAN_REMOTE && INPUT_POWERMATE && INPUT_YEALINK && INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 && IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD)
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> ---
>>  drivers/gpu/drm/Kconfig |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index 23120c0..45536db 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -23,6 +23,7 @@ config DRM_USB
>>       tristate
>>       depends on DRM
>>       select USB
>> +     select USB_SUPPORT
>
> User visible options shouldn't be selected. So instead of selecting
> all dependencies this should rather be:
>
>         depends on USB

In general what you suggested seems to be the right thing to do.
However in this particular case, making this "depends on" creates
recursive dependencies
and probably that is the reason Dave Airlie decided to make it "select USB" (?)


>
> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 
With warm regards,
Sachin