[PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call

InKi Dae inki.dae at samsung.com
Sun Aug 19 19:00:20 PDT 2012


2012/8/20 Joonyoung Shim <jy0922.shim at samsung.com>:
> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>
>> encoder's mode_set callback isn't specific to hardware so it doesn't
>> need to call exynos_drm_encoder_dpms().
>
>
> Then, where is exynos_drm_encoder_dpms() called?
>

with this patch series, exynos_drm_encoder_dpms() will call apply
callback to set local overlay data to real hardware registers and
exynos_drm_crtc_dpms() will be used to enable/disable fimd or hdmi
power(clock and regulator). actually, previous codes called mode_set
two times so this could make it messed up other display sub devices
such as mDNIe.

>
>>
>> Signed-off-by: Inki Dae <inki.dae at samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_encoder.c |    2 --
>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> index 2c037cd..3dae250 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> @@ -138,8 +138,6 @@ static void exynos_drm_encoder_mode_set(struct
>> drm_encoder *encoder,
>>         DRM_DEBUG_KMS("%s\n", __FILE__);
>>   -     exynos_drm_encoder_dpms(encoder, DRM_MODE_DPMS_ON);
>> -
>>         list_for_each_entry(connector, &dev->mode_config.connector_list,
>> head) {
>>                 if (connector->encoder == encoder)
>>                         if (manager_ops && manager_ops->mode_set)
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list