[PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 7 03:49:54 PST 2012


On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula at linux.intel.com> wrote:
> 
> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner at canonical.com> wrote:
> > +	if (!saved_mode) {
> > +		pr_err("i915: Could not allocate saved display mode.\n");
> 
> Please use DRM_ERROR().

Truthfully neither, but join the growing petition to get real errorcodes
back to userspace!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list