[PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()

Wei Yongjun weiyj.lk at gmail.com
Fri Dec 7 04:50:23 PST 2012


From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

In case of error, function arm_iommu_create_mapping() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
 drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
index 09db198..3b3d3a6 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
@@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
 	mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,
 						priv->da_space_size,
 						priv->da_space_order);
-	if (!mapping)
+	if (IS_ERR(mapping))
 		return -ENOMEM;
 
 	dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),




More information about the dri-devel mailing list