[PATCH 75/81] drm/i915: Drop some stale FIXMEs from the atomic code

ville.syrjala at linux.intel.com ville.syrjala at linux.intel.com
Wed Dec 12 08:16:42 PST 2012


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_atomic.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c
index 415cd72..efdaff3 100644
--- a/drivers/gpu/drm/i915/intel_atomic.c
+++ b/drivers/gpu/drm/i915/intel_atomic.c
@@ -717,7 +717,6 @@ static void crtc_commit(struct drm_crtc *crtc)
 	dev_priv->display.crtc_enable(&intel_crtc->base);
 
 	/* FIXME need to check where this stuff is used really */
-	/* FIXME need to update DPMS state somewhere */
 	list_for_each_entry(intel_encoder, &dev->mode_config.encoder_list, base.head) {
 		if (intel_encoder->base.crtc == crtc)
 			intel_encoder->connectors_active = true;
@@ -1210,8 +1209,6 @@ static void restore_state(struct drm_device *dev,
 	/* must restore the new_crtc and new_encoder pointers as well */
 	intel_modeset_update_staged_output_state(dev);
 
-	/* FIXME props etc. */
-
 	/* was the hardware state clobbered? */
 	if (s->restore_hw)
 		apply_config(dev, s);
@@ -1523,7 +1520,6 @@ static void update_crtc(struct drm_device *dev,
 		struct intel_crtc_state *st = &s->crtc[i];
 		struct drm_crtc *crtc = st->crtc;
 
-		/* FIXME is this OK? */
 		if (st->fb_dirty && !st->mode_dirty) {
 			mutex_lock(&dev->struct_mutex);
 			intel_update_fbc(dev);
-- 
1.7.8.6



More information about the dri-devel mailing list