[PATCH 20/20] drm: do not set fb_info->pixmap fields

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 1 04:00:11 PST 2012


On Wed,  1 Feb 2012 11:38:38 +0100, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> The drm drivers set the fb_info->pixmap fields without setting
> fb_info->pixmap.addr. If this is not set the fb core will overwrite
> these all fb_info->pixmap fields anyway, so there is not much point
> in setting them in the first place.

Might be worth replacing those blocks with a comment:
  /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list