radeon issues on MacBook Pro 8,2

[Alex Deucher]

On Tue, Jan 31, 2012 at 8:06 PM, Seth Forshee
<seth.forshee at canonical.com> wrote:
> On Fri, Jan 20, 2012 at 05:08:31PM -0600, Seth Forshee wrote:
>> > Can you track down who is calling the connector->detect() callbacks
>> > during suspend and resume?
>>
>> I got two different stack traces, see below.
>>
>> And to slightly amend my statement above, I'm only seeing the wrong
>> status returned on the suspend side of things. The status during resume
>> always seems to be correct.
>>
>>  Pid: 49, comm: kworker/0:2 Tainted: G         C O 3.2.0-10-generic #17-Ubuntu
>>  Call Trace:
>>   [<ffffffffa03f5e1e>] radeon_dp_detect+0x1de/0x230 [radeon]
>>   [<ffffffffa014ac6d>] output_poll_execute+0xbd/0x1a0 [drm_kms_helper]
>>   [<ffffffffa014abb0>] ? drm_helper_mode_fill_fb_struct+0x30/0x30 [drm_kms_helper]
>>   [<ffffffff81083dca>] process_one_work+0x11a/0x480
>>   [<ffffffff81084b74>] worker_thread+0x164/0x370
>>   [<ffffffff81084a10>] ? manage_workers.isra.30+0x130/0x130
>>   [<ffffffff810893cc>] kthread+0x8c/0xa0
>>   [<ffffffff81660674>] kernel_thread_helper+0x4/0x10
>>   [<ffffffff81089340>] ? flush_kthread_worker+0xa0/0xa0
>>   [<ffffffff81660670>] ? gs_change+0x13/0x13
>>
>>  Pid: 49, comm: kworker/0:2 Tainted: G         C O 3.2.0-10-generic #17-Ubuntu
>>  Call Trace:
>>   [<ffffffffa03f5e1e>] radeon_dp_detect+0x1de/0x230 [radeon]
>>   [<ffffffffa014b6b3>] drm_helper_probe_single_connector_modes+0x2c3/0x380 [drm_kms_helper]
>>   [<ffffffffa0149d42>] drm_fb_helper_hotplug_event+0xf2/0x150 [drm_kms_helper]
>>   [<ffffffffa03fe8d5>] radeon_fb_output_poll_changed+0x15/0x20 [radeon]
>>   [<ffffffffa03f7b65>] radeon_output_poll_changed+0x15/0x20 [radeon]
>>   [<ffffffffa014ad40>] output_poll_execute+0x190/0x1a0 [drm_kms_helper]
>>   [<ffffffffa014abb0>] ? drm_helper_mode_fill_fb_struct+0x30/0x30 [drm_kms_helper]
>>   [<ffffffff81083dca>] process_one_work+0x11a/0x480
>>   [<ffffffff81084b74>] worker_thread+0x164/0x370
>>   [<ffffffff81084a10>] ? manage_workers.isra.30+0x130/0x130
>>   [<ffffffff810893cc>] kthread+0x8c/0xa0
>>   [<ffffffff81660674>] kernel_thread_helper+0x4/0x10
>>   [<ffffffff81089340>] ? flush_kthread_worker+0xa0/0xa0
>>   [<ffffffff81660670>] ? gs_change+0x13/0x13
>
> From these traces it looks like all that really needs to happen is to
> disable the output polling during suspend. The following patch seems to
> get rid of the problems I'm seeing. Does this look okay to you?
>

Looks great.  Thanks for tracking this down.  We should probably cc
stable as well when this gets committed.

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

>
> From 0c01950f248c541198b7560793cf57c59b2c11f8 Mon Sep 17 00:00:00 2001
> From: Seth Forshee <seth.forshee at canonical.com>
> Date: Tue, 31 Jan 2012 15:37:02 -0600
> Subject: [PATCH 1/1] drm/radeon/kms: disable output polling when suspended
>
> Polling the outputs when the device is suspended can result in erroneous
> status updates. Disable output polling during suspend to prevent this
> from happening.
>
> Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
> ---
>  drivers/gpu/drm/radeon/radeon_device.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index cec51a5..49f7cb7 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -883,6 +883,8 @@ int radeon_suspend_kms(struct drm_device *dev, pm_message_t state)
>        if (dev->switch_power_state == DRM_SWITCH_POWER_OFF)
>                return 0;
>
> +       drm_kms_helper_poll_disable(dev);
> +
>        /* turn off display hw */
>        list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
>                drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
> @@ -972,6 +974,8 @@ int radeon_resume_kms(struct drm_device *dev)
>        list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
>                drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
>        }
> +
> +       drm_kms_helper_poll_enable(dev);
>        return 0;
>  }
>
> --
> 1.7.8.3
>