[PATCH] drm/radeon/kms/blit: fix blit copy for very large buffers

Ilija Hadzic ihadzic at research.bell-labs.com
Thu Feb 2 05:51:34 PST 2012



On Thu, 2 Feb 2012, Michel [ISO-8859-1] Dänzer wrote:


>> +#define I2F_MAX_BITS 15
>> +#define I2F_MAX_INPUT  ((2 << I2F_MAX_BITS) - 1)
>
> Should be ((1 << I2F_MAX_BITS) - 1): 2^n == (1 << n)
>

Right. I'll fix it.

> Use WARN_ON_ONCE here to avoid spamming the kernel output. If this is
> ever hit again, it won't happen just once.
>
>

I agree. v2 coming shortly.

-- Ilija


More information about the dri-devel mailing list