[PATCH 1/5] drm/vgem: virtual GEM provider

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 8 15:28:42 PST 2012


On Thu,  9 Feb 2012 00:19:27 +0100, Ben Widawsky <ben at bwidawsk.net> wrote:
> From: Adam Jackson <ajax at redhat.com>
> +static void vgem_gem_free_object(struct drm_gem_object *obj)
> +{
> +	if (obj->map_list.map)
> +		drm_gem_free_mmap_offset(obj);
> +
> +	drm_gem_object_release(obj);
> +}

drm_gem_free_mmap_offset() should be pushed down into
drm_gem_object_release(). Out of the 6 distinct users of
drm_gem_object_release(), 3 call drm_gem_free_mmap_offset() just prior
and gma500 forgets to.

I do accept that it is a separate patch though ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list