[PATCH 2/4] drm/radeon/kms: no need to align IB like this

[Jerome Glisse]

2012/2/23 Christian König <deathsimple at vodafone.de>

> So don't confuse devs by doing so.
>
> Signed-off-by: Christian König <deathsimple at vodafone.de>
> ---
>  drivers/gpu/drm/radeon/r600.c |   15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index 4f08e5e..4a4ac8f 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -2719,20 +2719,7 @@ int r600_ib_test(struct radeon_device *rdev, int
> ring)
>        ib->ptr[0] = PACKET3(PACKET3_SET_CONFIG_REG, 1);
>        ib->ptr[1] = ((scratch - PACKET3_SET_CONFIG_REG_OFFSET) >> 2);
>        ib->ptr[2] = 0xDEADBEEF;
> -       ib->ptr[3] = PACKET2(0);
> -       ib->ptr[4] = PACKET2(0);
> -       ib->ptr[5] = PACKET2(0);
> -       ib->ptr[6] = PACKET2(0);
> -       ib->ptr[7] = PACKET2(0);
> -       ib->ptr[8] = PACKET2(0);
> -       ib->ptr[9] = PACKET2(0);
> -       ib->ptr[10] = PACKET2(0);
> -       ib->ptr[11] = PACKET2(0);
> -       ib->ptr[12] = PACKET2(0);
> -       ib->ptr[13] = PACKET2(0);
> -       ib->ptr[14] = PACKET2(0);
> -       ib->ptr[15] = PACKET2(0);
> -       ib->length_dw = 16;
> +       ib->length_dw = 3;
>        r = radeon_ib_schedule(rdev, ib);
>        if (r) {
>                radeon_scratch_free(rdev, scratch);
> --
> 1.7.5.4
>

You sure about that ? I remember this helped with GPU lockup and i also
seen fglrx aligning IB.

Cheers,
Jerome
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20120223/f5977310/attachment.htm>