[PATCH] drm/radeon/kms: give better user feedback if a VM CS fails

[Alex Deucher]

On Mon, Feb 27, 2012 at 12:24 PM, David Airlie <airlied at redhat.com> wrote:
>
>> ---
>>  drivers/gpu/drm/radeon/radeon_cs.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_cs.c
>> b/drivers/gpu/drm/radeon/radeon_cs.c
>> index 9b4124e..f7ee2f8 100644
>> --- a/drivers/gpu/drm/radeon/radeon_cs.c
>> +++ b/drivers/gpu/drm/radeon/radeon_cs.c
>> @@ -420,6 +420,7 @@ static int radeon_cs_ib_vm_chunk(struct
>> radeon_device *rdev,
>>       }
>>       r = radeon_ring_ib_parse(rdev, parser->ring, parser->ib);
>>       if (r) {
>> +             DRM_ERROR("Invalid VM CS\n");
>>               return r;
>
> Isn't this user triggerable?

If they send a bad CS, sure.  It just brings the VM CS ioctl in line
with non-VM one which warns similarly.

Alex

>
> Dave.