[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

Michel Dänzer michel at daenzer.net
Wed Jan 4 02:34:45 PST 2012


On Mit, 2012-01-04 at 00:52 +0000, Alan Cox wrote: 
> On Tue, 03 Jan 2012 19:25:46 +0100
> Michel Dänzer <michel at daenzer.net> wrote:
> > On Die, 2012-01-03 at 18:09 +0000, Alan Cox wrote: 
> > > On Tue,  3 Jan 2012 19:04:00 +0100
> > > Michel Dänzer <michel at daenzer.net> wrote:
> > > 
> > > > From: Michel Dänzer <michel.daenzer at amd.com>
> > > > 
> > > > It can be called from atomic context, e.g. when switching to console for panic
> > > > output.
> > > 
> > > Is this only special cases like a panic - if so can it not be called in a
> > > way that distinguishes between normality and nasty cases.
> > 
> > No idea, to be honest. It's an ATOM BIOS interpreter opcode, so in
> > theory it could be indirectly called from anywhere that uses ATOM BIOS.
> 
> So lets stick to practice, and the real world. Screwing up everything
> else because of a crappy problem in your Atom BIOS code sucks but hey it
> happens. screwing up everything because of a theoretical concern is just
> dumb.

Thanks for the flowers, but it's not just a theoretical concern, see the
bug report.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the dri-devel mailing list