[PATCH] radeon: Use mdelay() instead of msleep() in atom_op_delay().

Dave Airlie airlied at gmail.com
Wed Jan 4 04:03:04 PST 2012


2012/1/4 Alan Cox <alan at lxorguk.ukuu.org.uk>:
>> > So lets stick to practice, and the real world. Screwing up everything
>> > else because of a crappy problem in your Atom BIOS code sucks but hey it
>> > happens. screwing up everything because of a theoretical concern is just
>> > dumb.
>>
>> Thanks for the flowers, but it's not just a theoretical concern, see the
>> bug report.
>
> The bug report is a single specific case. Figure out the calling
> paths afflicted by it, don't be lazy and just dump on everyone on every
> path because of a special case you apparently can't be bothered to root
> cause.
>

I'm not sure what we'd gain by passing the atomic context information
in from the top of the atom interpreter and using it in this one place
vs getting the atomic info in this one place.

Every modesetting operation can happen in atomic context or not in
atomic context, thanks to the wonder of oops printing and also kgdb,
trying to figure out which table in this one person's bios is the
"root" cause and special casing for it is insane since tomorrow 20
other BIOSes could contain that table or a new variant we haven't seen
before.

Unless one of us is totally misinterpreting what the other is saying
or what the atombios interpreter is.

Dave.


More information about the dri-devel mailing list