[patch] drm/nv50/pm: signedness bug in nv50_pm_clocks_pre()

[Martin Peres]

Le 04/01/2012 08:20, Dan Carpenter a écrit :
> calc_mclk() returns zero on success and negative on failure but clk is
> a u32.
>
> Signed-off-by: Dan Carpenter<dan.carpenter at oracle.com>
>
> diff --git a/drivers/gpu/drm/nouveau/nv50_pm.c b/drivers/gpu/drm/nouveau/nv50_pm.c
> index 0393721..3508de9 100644
> --- a/drivers/gpu/drm/nouveau/nv50_pm.c
> +++ b/drivers/gpu/drm/nouveau/nv50_pm.c
> @@ -540,7 +540,7 @@ nv50_pm_clocks_pre(struct drm_device *dev, struct nouveau_pm_level *perflvl)
>   	info->mclk_hwsq.len = 0;
>   	if (perflvl->memory) {
>   		clk = calc_mclk(dev, perflvl->memory,&info->mclk_hwsq);
> -		if (clk<  0) {
> +		if ((int)clk<  0) {
>   			ret = clk;
>   			goto error;
>   		}
Well spotted Dan!

Sorry for the late answer, was busy reworking this file for safe reclocking.

I have a slightly different fix for that. Please tell me if It suits 
you: 
https://gitorious.org/linux-nouveau-pm/linux-nouveau-pm/commit/c1b80360ezd1aa7dd780ac383aae9437c66ef3b89