[patch] drm/nouveau/dp: nouveau_dp_link_train() returns bool

Dan Carpenter dan.carpenter at oracle.com
Sun Jan 15 03:31:05 PST 2012


The caller doesn't check the return value, but this function returns a
bool so static checkers complain when we return a negative error code.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
index 9b93b70..dcffd13 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dp.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
@@ -573,7 +573,7 @@ nouveau_dp_link_train(struct drm_encoder *encoder, u32 datarate)
 
 	dp.table = nouveau_dp_bios_data(dev, nv_encoder->dcb, &dp.entry);
 	if (!dp.table)
-		return -EINVAL;
+		return false;
 
 	dp.dcb = nv_encoder->dcb;
 	dp.crtc = nv_crtc->index;


More information about the dri-devel mailing list