libdrm fails 'make check' in tinderbox (was Re: [ANNOUNCE] libdrm 2.4.30)

Sat Jan 28 12:57:10 PST 2012

libdrm is still failing 'make check':

Linux/ppc   - http://tinderbox.x.org/builds/2012-01-28-0007/logs/libdrm/#check
Linux/ppc64 - http://tinderbox.x.org/builds/2012-01-28-0013/logs/libdrm/#check

I bisected it to the commit below (which added the failing tests).  Are these tests broken?  Can they please be disabled until they are working?

683855f65523c978562ead56f9d68f50ffdca1a2 is the first bad commit
commit 683855f65523c978562ead56f9d68f50ffdca1a2
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Jan 3 14:32:18 2012 -0800

    intel: Add regression tests for batch decode.

    The .batch was generated using the dump-a-batch branch of

    git://people.freedesktop.org/~anholt/mesa

    using glxgears on gen7 hardware, using INTEL_DEVID_OVERRIDE for
    non-gen7 (this means that offsets in the buffers for non-gen7 are 0!).
    The .ref was generated by:

    ./test_decode tests/gen7-3d.batch -dump.

    The .sh exists because you can't supply arguments to tests using the
    simple automake tests driver.  Something reasonable could be done
    using automake's parallel-tests driver (in fact, a previous version of
    the patch did that), but I was concerned that:

    1) The parallel-tests driver is documented to be unstable -- they may
       change interfaces on us later.
    2) The parallel-tests driver hides the output of tests in .log files
       scattered all over the tree, which was ugly and more painful to
       work with.

    v2: Actually add the batch files, add a .gitignore for the *-new.txt
        files added after failures, and fix failure mode for undetected
        chipset name.
    Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> (v1)

:040000 040000 0154ee50d82d218ae87cacbb4fd7dbc45bc1e0cb de793dcf57aa48470928f754c6f5dbb4a123253f M	intel

$ git bisect log
git bisect start
# good: [7fd1678110b78d9324723a54dfd5049496b9e3cf] configure: Bump version for 2.4.29
git bisect good 7fd1678110b78d9324723a54dfd5049496b9e3cf
# bad: [b643b0713aefdc0611e47654e88263b53b0de6f5] intel: Add minimal decode for remaining gen7 packets in use.
git bisect bad b643b0713aefdc0611e47654e88263b53b0de6f5
# bad: [683855f65523c978562ead56f9d68f50ffdca1a2] intel: Add regression tests for batch decode.
git bisect bad 683855f65523c978562ead56f9d68f50ffdca1a2
# skip: [07768babb81bf8b9b993c41e7dca1e011fd6bd69] intel: Fix Wsigned-compare warnings (soon to be enabled).
git bisect skip 07768babb81bf8b9b993c41e7dca1e011fd6bd69
# good: [a9dd34a7ee9d03d357e15f045ab85a12f6f6e4b8] intel/intel_decode.c: Remove #include "intel_decode.h".
git bisect good a9dd34a7ee9d03d357e15f045ab85a12f6f6e4b8
# good: [ccbc40340b7b472939a90ae8afc0a82b358ce189] intel: Add a regression test program for intel_decode.c.
git bisect good ccbc40340b7b472939a90ae8afc0a82b358ce189

On Jan 7, 2012, at 11:22, Jeremy Huddleston wrote:

> This new libdrm fails 'make check' on tinderbox:
> http://tinderbox.x.org/builds/2012-01-07-0023/logs/libdrm/#check
> 
> On Jan 6, 2012, at 8:54 AM, Eric Anholt wrote:
> 
>> Here's a new release, featuring updated i915_drm.h for gen7 transform
>> feedback, and intel_decode.c as a library API instead of being copied
>> around between our various driver components.
>> 
>> Chris Wilson (2):
>>     intel: Reset vma list upon purge
>>     tests/gem_flink: Check for MASTER before proceeding
>> 
>> Eric Anholt (18):
>>     intel: Import intel_decode.c from intel-gpu-tools.
>>     intel: Make intel_chipset handle devid directly.
>>     intel: intel: Add IS_GEN[567] macros.
>>     intel: Reformat intel_decode.c from intel-gpu-tools using Lindent.
>>     intel: Minor style tweaks after Lindent.
>>     intel: Get intel_decode.c minimally building.
>>     intel: Fix Wsigned-compare warnings (soon to be enabled).
>>     intel: Fix a ton of signed vs unsigned and const char *warnings
>>     intel: Add printflike warnings for instr_out.
>>     intel: Fix printf format warnings for intel_decode.
>>     intel: Remove c99ish variable declarations.
>>     intel: Turn on normal warnings for intel_decode.c build.
>>     intel: Disable unused decode_logic_op().
>>     intel: Add an interface for setting the output file for decode.
>>     intel: Add a regression test program for intel_decode.c.
>>     intel: Add regression tests for batch decode.
>>     intel: Update for new i915_drm.h defines.
>>     configure: Bump version for 2.4.30
>> 
>> Jesse Barnes (1):
>>     libdrm: update drm headers from kernel, including new overlay ioctls & structs
>> 
>> Johannes Obermayr (1):
>>     intel/intel_decode.c: Remove #include "intel_decode.h".
>> 
>> git tag: 2.4.30
>> 
>> http://dri.freedesktop.org/libdrm/libdrm-2.4.30.tar.bz2
>> MD5:  9f57a68b2c0836b55ebcbc241f6ca175  libdrm-2.4.30.tar.bz2
>> SHA1: 5ba36a0bcbacbe67e6a2e0d5318ed9455da59bbc  libdrm-2.4.30.tar.bz2
>> SHA256: cacea9c157ec824ad278a06f4910659b2f3ae69686518ece8d6967843cddcd56  libdrm-2.4.30.tar.bz2
>> 
>> http://dri.freedesktop.org/libdrm/libdrm-2.4.30.tar.gz
>> MD5:  cd790fb761a83125eceb64162d7d5ce5  libdrm-2.4.30.tar.gz
>> SHA1: 148936f0c0f83d016c584245493b975d42bd359a  libdrm-2.4.30.tar.gz
>> SHA256: a64e63a2af08bcab835e758048611cf61c7183dc7e829cad9dceba859245b4bc  libdrm-2.4.30.tar.gz
>> 
>> _______________________________________________
>> xorg-announce mailing list
>> xorg-announce at lists.x.org
>> http://lists.x.org/mailman/listinfo/xorg-announce
> 