[PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jan 31 01:42:59 PST 2012


Hi Sumit,

> On Friday 27 January 2012 10:43:28 Sumit Semwal wrote:

[snip]

>  static inline void dma_buf_unmap_attachment(struct dma_buf_attachment
> *attach,
> -                                            struct sg_table *sg)
> +                     struct sg_table *sg, enum dma_data_direction write)

On a second thought, would it make sense to store the direction in struct 
dma_buf_attachment in dma_buf_map_attachment(), and pass the value directly to 
the .unmap_dma_buf() instead of requiring the dma_buf_unmap_attachment() 
caller to remember it ? Or is an attachment allowed to map the buffer several 
times with different directions ?

-- 
Regards,

Laurent Pinchart


More information about the dri-devel mailing list