[RFC] drm/radeon: restoring ring commands in case of a lockup

Christian König deathsimple at vodafone.de
Tue Jul 10 05:54:57 PDT 2012


On 09.07.2012 18:10, Jerome Glisse wrote:
> On Mon, Jul 9, 2012 at 11:59 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On Mon, 2012-07-09 at 12:41 +0200, Christian König wrote:
>>> Hi,
>>>
>>> The following patchset tries to save and restore the not yet processed commands
>>> from the rings in case of a lockup and with that should make a userspace
>>> problem with a single application far less problematic.
>>>
>>> The first four patches are just stuff this patchset is based upon, followed by
>>> four patches which fix various bugs found while working on this feature.
>>>
>>> Followed by patches which change the way how memory is saved/restored on
>>> suspend/resume, basically before we have unpinned most of the buffer objects so
>>> it could be move from vram into system memory. But that is mostly unnecessary
>>> cause the buffer object either are already in system memory or their content
>>> can be easily reinitialized.
>>>
>>> The last three patches implement the actual tracking and restoring of commands
>>> in case of a lockup. Please take a look and review.
>> Patches 3, 5 and 14 are
>>
>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>
> Patch 1-9 are
> Reviewed-by: Jerome Glisse <jglisse at redhat.com>
>
> Other looks good but i want to test them too and spend a bit more time
> to double check few things. Will try to do that tomorrow.
Just send out v2 of the patchset. Mainly it integrates your idea of just 
saving rptr right before we call into the IB, but also contains all the 
other comments and fixes from Michel.

Cheers,
Christian.


More information about the dri-devel mailing list