libdrm: Fix some warnings reported by clang's scan-build tool [try 2]
Johannes Obermayr
johannesobermayr at gmx.de
Fri Jul 13 11:34:20 PDT 2012
Am Freitag, 13. Juli 2012, 18:47:50 schrieb Marcin Slusarz:
> On Fri, Jul 13, 2012 at 05:49:12PM +0200, Johannes Obermayr wrote:
> >
> > Patches 1 to 4 were sent to mesa-dev.
>
> And you chose to ignore most of my comments.
> Fine. Don't expect further reviews from me.
>
> Marcin
Patch 1 and 2:
- Adapted
- I want to keep proposed easier to read "switch" case
Patch 3:
- Resend
- Waiting on your response: http://lists.freedesktop.org/archives/mesa-dev/2012-June/023456.html
Patch 4 and 5:
- Splitted
- http://llvm.org/bugs/show_bug.cgi?id=13358 (forgot to split and to add 'drmFree(list);')
- The 'more if's case' seems better to me
Patch 6:
- Resend
Marcin, not that I ignore comments. But sometimes I want to hear also opinions from (some more) other people.
I hope I can calm the waves ...
Johannes
More information about the dri-devel
mailing list