[patch] drm/radeon: check for allocation failure in radeon_ring_backup()

Dan Carpenter dan.carpenter at oracle.com
Fri Jul 20 07:35:25 PDT 2012


On Fri, Jul 20, 2012 at 03:45:28PM +0200, Christian König wrote:
> On 20.07.2012 13:17, Dan Carpenter wrote:
> >Static checkers complain if this we don't check for allocation failure.
> >Also we can use the new kmalloc_array() function here as a cleanup.
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> What's the benefit of using kmalloc_array instead of just kmalloc?
> 

It has built in integer overflow protection.  Whenever I see
multiplication in kmalloc(), I automatically start to audit for
overflows, but now, ha ha, just change it to kmalloc_array() and
forget about it.  (There weren't any integer overflow problems
in the original code, btw).

regards,
dan carpenter



More information about the dri-devel mailing list