[PATCH 3/3] drm/i915: be more paranoid with the flink name refcounting

Daniel Vetter daniel.vetter at ffwll.ch
Mon Jul 23 01:27:27 PDT 2012


We should _never_ call handle_unref without having a name handle.
Doing so would be a bug, so yell around about if this happens with a
loud WARN_ON.

Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 include/drm/drmP.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 3837e69..d94c6bd 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1677,7 +1677,7 @@ drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj)
 	if (obj == NULL)
 		return;
 
-	if (atomic_read(&obj->handle_count) == 0)
+	if (WARN_ON(atomic_read(&obj->handle_count) == 0))
 		return;
 
 	/*
-- 
1.7.10.4



More information about the dri-devel mailing list