[PATCH] drm/radeon: add new AMD ACPI header and update relevant code

[Luca Tettamanti]

On Mon, Jul 30, 2012 at 10:30 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Mon, Jul 30, 2012 at 4:24 PM, Luca Tettamanti <kronos.it at gmail.com> wrote:
>> On Mon, Jul 30, 2012 at 10:20:15AM -0400, Alex Deucher wrote:
>>> Supported     DWORD Bit vector providing supported functions
>>> information. Each bit marks
>>> Functions Bit              support for one specific function of the
>>> ATIF method. Bit n, if set,
>>> Vector                        indicates that Function n+1 is supported.
>>
>> Sorry, I still don't understand it... what's "Function n+1" in this
>> context?
>> Does this mean that if bit n is set then the function defined as
>> 1 << (n+1) is supported?
>
> It means if bit n is set in teh supported function vector, function
> n+1 is supported.  E.g., if bit 1 is set, function 2
> (ATIF_FUNCTION_GET_SYSTEM_BIOS_REQUESTS) is supported.  If bit 3 is
> set function 4 (ATIF_FUNCTION_GET_LID_STATE) is supported, etc.

Great, just had an epiphany ;-) "n+1" refers to the value that's
passed down to ATIF, I was still thinking in terms of bitmasks...
Ok, so my code is correct, BIOS is botched... meh.

L