[drm-fixes][PATCH 3.5] drm/radeon/hdmi: don't set SEND_MAX_PACKETS bit

Alex Deucher alexdeucher at gmail.com
Mon Jun 4 12:29:24 PDT 2012


On Mon, Jun 4, 2012 at 2:18 PM, Rafał Miłecki <zajec5 at gmail.com> wrote:
> Many TVs and A/V receivers don't work with this bit set. Problem was
> confirmed using: Onkyo TX-SR605, Sony BRAVIA KDL-52X3500, Sony BRAVIA
> KDL-40S40xx. In theory this bit shouldn't affect audio engine when
> feeding it with data, however it seems it does. Driver fglrx doesn't set
> that bit in any of the above cases.
> This fixes a regression introduced by 3.5-rc1.
>
> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/radeon/r600_hdmi.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c
> index 226379e..969c275 100644
> --- a/drivers/gpu/drm/radeon/r600_hdmi.c
> +++ b/drivers/gpu/drm/radeon/r600_hdmi.c
> @@ -348,7 +348,6 @@ void r600_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *mod
>                WREG32(HDMI0_AUDIO_PACKET_CONTROL + offset,
>                       HDMI0_AUDIO_SAMPLE_SEND | /* send audio packets */
>                       HDMI0_AUDIO_DELAY_EN(1) | /* default audio delay */
> -                      HDMI0_AUDIO_SEND_MAX_PACKETS | /* send NULL packets if no audio is available */
>                       HDMI0_AUDIO_PACKETS_PER_LINE(3) | /* should be suffient for all audio modes and small enough for all hblanks */
>                       HDMI0_60958_CS_UPDATE); /* allow 60958 channel status fields to be updated */
>        }
> --
> 1.7.7
>


More information about the dri-devel mailing list