[PATCH 4/4] drm: Renesas SH Mobile DRM driver

[Lars-Peter Clausen]

On 06/27/2012 10:27 PM, Laurent Pinchart wrote:
> Hi Lars-Peter,
> 
> On Wednesday 27 June 2012 22:06:54 Lars-Peter Clausen wrote:
>> On 06/27/2012 02:40 PM, Laurent Pinchart wrote:
>>> Hi Lars-Peter,
>>>
>>> [...]
>>>
>>> Do you plan to post a v3 of your "DRM: Add DRM kms/fb cma helper" patch in
>>> the near future ?
>>
>> Hi Laurent,
>>
>> I don't think there have been any changes since v2 except for adjusting to
>> the renamed functions in Sascha's patch. I'll send a v3 tomorrow.
> 
> OK, thanks.
> 
> As Ville pointed out, we need to validate the offsets and make sure the frame 
> buffer fits in the GEM object(s). I don't think there's code in your patch to 
> do so, have you thought about where/how to implement that ?

I think part of it needs to be done in the driver code, since the the generic
code does not the specific buffer layout requirements imposed by the hardware.
We can probably add some basic sanity checks for the buffer size though.

- Lars