[PATCH 1/3] drm/radeon: move ring locking out of reset path

[Michel Dänzer]

On Fre, 2012-06-29 at 17:18 +0200, Christian König wrote: 
> On 29.06.2012 17:09, Michel Dänzer wrote:
> > On Fre, 2012-06-29 at 16:45 +0200, Christian König wrote:
> >> Hold the ring lock the whole time the reset is in progress,
> >> otherwise another process can submit new jobs.
> > Sounds good, but doesn't this create other paths (e.g. initialization,
> > resume) where the ring is being accessed without holding the lock? Isn't
> > that a problem?
> 
> Thought about that also.
> 
> For init I'm pretty sure that no application can submit commands before 
> we are done, otherwise we are doomed anyway.
> 
> For resume I'm not really sure, but I think that applications are 
> resumed after the hardware driver had a chance of doing so.

I hope you're right... but if it's not too much trouble, it might be
better to be safe than sorry and take the lock for those paths as well.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer