[Bug 45558] cannot render on a drawable of size equal the max framebuffer size

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45558

Eric Anholt <eric at anholt.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Eric Anholt <eric at anholt.net> 2012-03-02 17:31:52 PST ---
The BLT ranges are exclusive -- it's only the drawrect that has that oddness. 
I pushed that part of the patch, and it does almost entirely fix gnome-shell
rendering.

commit 7d13a6e64bf88566875a8f68e0aac9b937e30feb
Author: Alban Browaeys <prahal at yahoo.com>
Date:   Thu Feb 2 19:20:22 2012 +0100

    dri/i915: Fix off-by-one in i830 clip region size.

    The hardware, like i915, uses an inclusive bounds on min and max for
    the drawing rectangle, but we were providing a number for exclusive.
    The number of bits used by the hardware only covers this value going
    up to the maximum size, so when we programmed 2048 as the maximum
    inclusive X, it saw a maximum X of 0 and clipped all rendering.  This
    caused rendering failures in gnome-shell.

    Fixes piglit fbo-maxsize.

    v2: dropped changes to the blitter, which does use an exclusive x2, y2.
        [change by anholt]

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45558
    Reviewed-by: Eric Anholt <eric at anholt.net>
    NOTE: This is a candidate for release branches.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.