[PATCH 6/7 v6] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

Chris Wilson chris at chris-wilson.co.uk
Wed Mar 28 11:53:24 PDT 2012


On Thu, 29 Mar 2012 02:26:38 +0800, Daniel Kurtz <djkurtz at chromium.org> wrote:
> Save the GMBUS2 value read while polling for state changes, and then
> reuse this value when determining for which reason the loops were exited.
> This is a small optimization which saves a couple of bus accesses for
> memory mapped IO registers.
> 
> To avoid "assigning in if clause" checkpatch errors", use a ret variable
> to store the wait_for macro return value.
> 
> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list