[PATCH 11/16] drm: properly free id_list when a render node is removed
Ilija Hadzic
ihadzic at research.bell-labs.com
Thu Mar 29 09:41:33 PDT 2012
id_list is dynamically allocated when a render node is
created. Consequently, if must be freed when the render node
is removed, otherwise we have a memory leak.
Signed-off-by: Ilija Hadzic <ihadzic at research.bell-labs.com>
---
drivers/gpu/drm/drm_stub.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index e316a69..e41882a 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -426,10 +426,13 @@ int drm_destroy_render_node(struct drm_device *dev, int index)
list_for_each_entry_safe(node, tmp, &dev->render_node_list, list) {
if (node->minor->index == index) {
+ struct drm_mode_group *group;
if (node->minor->open_count)
return -EBUSY;
+ group = &node->minor->mode_group;
list_del(&node->list);
drm_put_minor(&node->minor);
+ drm_mode_group_fini(group);
kfree(node);
return 0;
}
@@ -442,8 +445,11 @@ void drm_destroy_all_render_nodes(struct drm_device *dev)
struct drm_render_node *node, *tmp;
list_for_each_entry_safe(node, tmp, &dev->render_node_list, list) {
+ struct drm_mode_group *group;
+ group = &node->minor->mode_group;
list_del(&node->list);
drm_put_minor(&node->minor);
+ drm_mode_group_fini(group);
kfree(node);
}
}
--
1.7.8.5
More information about the dri-devel
mailing list