[PATCH 04/16] drm: initial multiple nodes ioctl work.

Ilija Hadzic ihadzic at research.bell-labs.com
Thu Mar 29 10:22:20 PDT 2012



On Thu, 29 Mar 2012, Ville [iso-8859-1] Syrjälä wrote:

>> +/* render node create and remove functions
>> +   if crtc/encoders/connectors all == 0 then gpgpu node */
>> +struct drm_render_node_create {
>> +	__u32 node_minor_id;
>> +	__u32 num_crtc;
>> +	__u32 num_encoder;
>> +	__u32 num_connector;
>
> num_plane is missing
>

Probably because at the time the original patch was created, there was no 
support for planes. I agree, we need to throw planes into this, but I'd 
prefer to do this as a follow-on patch series, rather than amending old 
patches. If for no better reason, than to keep simple relationship between 
the code and it's author (this particular patch is original Dave's patch 
from the days when we had no planes, only rebased to current HEAD).

-- Ilija


More information about the dri-devel mailing list