[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

Daniel Vetter daniel at ffwll.ch
Wed May 30 03:02:19 PDT 2012


On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote:
> > On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote:
> > > The passed mode must not be modified by the operation, make it const.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > 
> > Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Thank you for the ack. Would you also be so kind as to tell me how to fix the 
> related i915 issue (as briefly stated in the patch, the i915 driver modifies 
> mode->clock in intel_dp_mode_fixup()) ? Or, even better, provide a patch for 
> that ? :-)

Oops, lack of coffee. Patch is in the works. Btw, do you plan to constify
other stuff?
-Daneil
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the dri-devel mailing list