[PATCH] kms: Return a negative error code in kms_bo_create()

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Nov 1 02:38:42 PDT 2012


The function returns returns 0 on success or a negative value in case of an
error, except when given invalid attributes in which case it returns the
positive EINVAL value. Replace that with -EINVAL to allow the caller to detect
errors with a < 0 check.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 libkms/api.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libkms/api.c b/libkms/api.c
index 4a05f3d..5befaa0 100644
--- a/libkms/api.c
+++ b/libkms/api.c
@@ -80,7 +80,7 @@ int kms_bo_create(struct kms_driver *kms, const unsigned *attr, struct kms_bo **
 			type = value;
 			break;
 		default:
-			return EINVAL;
+			return -EINVAL;
 		}
 	}
 
-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list