[PATCH 1/1] drm/udl: Add missing static storage class specifiers in udl_connector.c

[Alex Deucher]

On Mon, Nov 19, 2012 at 12:27 AM, Sachin Kamat <sachin.kamat at linaro.org> wrote:
> Fixes the following sparse warnings:
> drivers/gpu/drm/udl/udl_connector.c:80:20: warning:
> symbol 'udl_best_single_encoder' was not declared. Should it be static?
> drivers/gpu/drm/udl/udl_connector.c:93:5: warning:
> symbol 'udl_connector_set_property' was not declared. Should it be static?
> drivers/gpu/drm/udl/udl_connector.c:106:35: warning:
> symbol 'udl_connector_helper_funcs' was not declared. Should it be static?
> drivers/gpu/drm/udl/udl_connector.c:112:28: warning:
> symbol 'udl_connector_funcs' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/udl/udl_connector.c |   12 +++++++-----
>  1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
> index b3b2ced..25b93de 100644
> --- a/drivers/gpu/drm/udl/udl_connector.c
> +++ b/drivers/gpu/drm/udl/udl_connector.c
> @@ -84,7 +84,8 @@ udl_detect(struct drm_connector *connector, bool force)
>         return connector_status_connected;
>  }
>
> -struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector)
> +static struct drm_encoder*
> +udl_best_single_encoder(struct drm_connector *connector)
>  {
>         int enc_id = connector->encoder_ids[0];
>         struct drm_mode_object *obj;
> @@ -97,8 +98,9 @@ struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector)
>         return encoder;
>  }
>
> -int udl_connector_set_property(struct drm_connector *connector, struct drm_property *property,
> -                              uint64_t val)
> +static int udl_connector_set_property(struct drm_connector *connector,
> +                                     struct drm_property *property,
> +                                     uint64_t val)
>  {
>         return 0;
>  }
> @@ -110,13 +112,13 @@ static void udl_connector_destroy(struct drm_connector *connector)
>         kfree(connector);
>  }
>
> -struct drm_connector_helper_funcs udl_connector_helper_funcs = {
> +static struct drm_connector_helper_funcs udl_connector_helper_funcs = {
>         .get_modes = udl_get_modes,
>         .mode_valid = udl_mode_valid,
>         .best_encoder = udl_best_single_encoder,
>  };
>
> -struct drm_connector_funcs udl_connector_funcs = {
> +static struct drm_connector_funcs udl_connector_funcs = {
>         .dpms = drm_helper_connector_dpms,
>         .detect = udl_detect,
>         .fill_modes = drm_helper_probe_single_connector_modes,
> --
> 1.7.4.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel