[PATCH 02/10] drm/ttm: remove ttm_bo_cleanup_memtype_use

Maarten Lankhorst maarten.lankhorst at canonical.com
Mon Nov 19 06:03:11 PST 2012


Op 19-11-12 14:26, Thomas Hellstrom schreef:
> Hi,
>
> On 11/12/2012 03:00 PM, Maarten Lankhorst wrote:
>> move to release_list instead
>
> Can you describe why this change is made? cleanup? reorder locks in a later patch?
> Also please describe why you need move_notify and ttm unbind / destroy to be outside of
> reservation, because that's the main change in this patch and it's not even mentioned in the
> commit message.
Ok is a reword enough? In that case I'll resend.

I moved all the destruction to happen when release_list refcount drops to 0.
This removes the special handling of ttm_bo_cleanup_memtype_use, and
makes it part of the normal bo destruction instead.

It also meant that move_notify and unbind/destroy was without reservation, simply
because it was done during normal destruction instead. At that point you may no longer
hold a reservation, but you can already be sure you're the only one touching it.

It is optional and I can drop this patch if the behavior change is unwanted.

~Maarten



More information about the dri-devel mailing list