[PATCH] drm/i915: set the AVI VIC of the HDMI mode

Daniel Vetter daniel at ffwll.ch
Wed Nov 21 08:09:31 PST 2012


On Wed, Nov 21, 2012 at 5:08 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Wed, Nov 21, 2012 at 4:47 PM, Thierry Reding
> <thierry.reding at avionic-design.de> wrote:
>> Oh great, so I copied that table for nothing. Thanks for Cc'ing, I can
>> reuse that in the HDMI infoframe series.
>
> Wrt the infoframe series, I think it'd be awesome if you could convert
> i915 and radeon (iirc the existing drivers with the "best" avi
> infoframe support) over to the new code. This gives some nice
> validation, both by testing on actual hw and that the interface is
> sane, since it'll be used by 2-3 different drivers then.
>
> I think the best way is to pick the infoframe implementation you best
> like from one of these, move it into the helper, then improve it until
> you're happy. And then convert over 1-2 other drivers. At least that's
> been my approach for the recent dp helper refactoring.

And if you could use that opportunity to integrate the kerneldoc for
edid/eld and the new infoframe code into the drm docbook, that would
be rather awesome ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list