[PATCH 2/5] drm/exynos: Use devm_gpio_request in exynos_hdmi.c

Sachin Kamat sachin.kamat at linaro.org
Thu Nov 22 23:03:03 PST 2012


On 23 November 2012 12:21, Inki Dae <inki.dae at samsung.com> wrote:
[snip]

> With cleanup to hdmi_resources_init, we can remove hdmi_resource_cleanup
> function. So could you please re-send updated patches?

OK. I will update and re-send.

>
> You've been submitting patches into too small pieces.
> Because they are trivial enough and in the same context, please merge this
> kind of patches as long as they are related with the same class or topics. I
> think you can combine them. :)

Generally, the accepted practice is to combine patches if they do
similar changes in the same file.
Else, separate patches is preferred as it makes things easier for
reviewers and maintainer by improving readability and less rework
effort.
Since you have specifically requested for combining the patches I will
squash patches related to clk_get together and resend the series.

>
> Thanks,
> Inki Dae
>


-- 
With warm regards,
Sachin


More information about the dri-devel mailing list