[PATCH V6 2/2] video: drm: exynos: Add device tree support
swarren at wwwdotorg.org
Mon Oct 1 09:20:44 PDT 2012
On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote:
> Hello Stephen Warren,
> The binding names that I use in my dts file should match with the
> names given in http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
I don't think so; the binding in that link is for example:
> + - xres, yres: Display resolution
> + - left-margin, right-margin, hsync-len: Horizontal Display timing parameters
> + in pixels
> + upper-margin, lower-margin, vsync-len: Vertical display timing parameters in
> + lines
> + - clock: displayclock in Hz
i.e. a bunch of separate properties, one for each value needed to
describe the display timing. However, your patch contains:
>>> + - samsung,fimd-display: This property should specify the phandle of the
>>> + display device node which holds the video interface timing with the
>>> + below mentioned properties.
>>> + - lcd-htiming: Specifies the horizontal timing for the overlay. The
>>> + horizontal timing includes four parameters in the following order.
>>> + - horizontal back porch (in number of lcd clocks)
>>> + - horizontal front porch (in number of lcd clocks)
>>> + - hsync pulse width (in number of lcd clocks)
>>> + - Display panels X resolution.
A single lcd-htiming property, which contains 4 values. (and a similar
construct for the vertical timing).
That seems entirely different to me...
More information about the dri-devel