[RFC 2/4] drm: make memset/calloc for _vblank_time more robust
Imre Deak
imre.deak at intel.com
Fri Oct 5 06:37:00 PDT 2012
Using sizeof(*var) instead of sizeof(var_type) allows changing var_type
w/o breaking callers that depend on the size.
Signed-off-by: Imre Deak <imre.deak at intel.com>
---
drivers/gpu/drm/drm_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 076c4a8..77f6577 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -90,7 +90,7 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
static void clear_vblank_timestamps(struct drm_device *dev, int crtc)
{
memset(&dev->_vblank_time[crtc * DRM_VBLANKTIME_RBSIZE], 0,
- DRM_VBLANKTIME_RBSIZE * sizeof(struct timeval));
+ DRM_VBLANKTIME_RBSIZE * sizeof(dev->_vblank_time[0]));
}
/*
@@ -248,7 +248,7 @@ int drm_vblank_init(struct drm_device *dev, int num_crtcs)
goto err;
dev->_vblank_time = kcalloc(num_crtcs * DRM_VBLANKTIME_RBSIZE,
- sizeof(struct timeval), GFP_KERNEL);
+ sizeof(dev->_vblank_time[0]), GFP_KERNEL);
if (!dev->_vblank_time)
goto err;
--
1.7.9.5
More information about the dri-devel
mailing list