[PATCH] radeon: Prevent confusion when fimware loading fails

Daniel J Blueman daniel at quora.org
Fri Oct 12 00:54:52 PDT 2012


When firmware loading fails eg due to running a newer kernel and hardware
on an older distro, prevent the user confusing this subsequent warning
backtrace with the real issue further up, ie "failed to load firmware",
which doesn't produce a backtrace.

Signed-off-by: Daniel J Blueman <daniel at quora.org>
---
 drivers/gpu/drm/radeon/evergreen.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c
index e93b80a..444cdf5 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -2416,7 +2416,7 @@ int evergreen_irq_set(struct radeon_device *rdev)
 	u32 afmt1 = 0, afmt2 = 0, afmt3 = 0, afmt4 = 0, afmt5 = 0, afmt6 = 0;
 
 	if (!rdev->irq.installed) {
-		WARN(1, "Can't enable IRQ/MSI because no handler is installed\n");
+		dev_warn(rdev->dev, "not enabling IRQ/MSI as no handler is installed\n");
 		return -EINVAL;
 	}
 	/* don't enable anything if the ih is disabled */
-- 
1.7.9.5



More information about the dri-devel mailing list