[PATCH 00/10] extract dp helper functions
daniel at ffwll.ch
Mon Oct 22 14:30:14 PDT 2012
On Thu, Oct 18, 2012 at 09:30:01AM -0400, Alex Deucher wrote:
> On Thu, Oct 18, 2012 at 4:15 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > Hi all,
> > I've frustrated myself the last few days yelling at our link training code.
> > Comparing the i915 code to radeon and nouveau I've noticed the lack of a nice
> > set of dp helper functions. So I've started to extract a few.
> > There's lots more that we can do I think (link configuration selection, the i2c
> > over aux retry stuff which diverges already between i915 and radeon, maybe more
> > higher level parts of the training sequence). But there the drivers diverge
> > quite a bit (e.g. the link configuration is driver by different things in each
> > driver: coded link bw from the dp spec, link clock or required bw vs avialable
> > bw), so that's more work and probably best done when reworking these functions
> > for other reasons.
> > I've also tried to put the new helpers a bit to use in nouveau, but due to lack
> > of hw that part is untested.
> > Comments and testing highly welcome.
> Looks good to me. Other than the minor change required in patch7,
> this series is:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
Slurped into drm-intel-next, with all the nouveau patches and hunks
dropped (I'll pester Ben once this has landed in drm-next), as discussed
on irc. Thanks for reviewing this pile.
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dri-devel