[PATCH 2/2] drm: add support for monotonic vblank timestamps
imre.deak at intel.com
Wed Oct 24 04:40:40 PDT 2012
On Wed, 2012-10-24 at 10:08 +0200, Michel Dänzer wrote:
> On Die, 2012-10-23 at 21:53 +0300, Imre Deak wrote:
> > Jumps in the vblank and page flip event timestamps cause trouble for
> > clients, so we should avoid them. The timestamp we get currently with
> > gettimeofday can jump, so use instead monotonic timestamps.
> > For backward compatibility use a module flag to revert back to using
> > gettimeofday timestamps. Add also a DRM_CAP_TIMESTAMP_MONOTONIC flag
> > that is simply a read only version of the module flag, so that clients
> > can query this without depending on sysfs.
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> drm_timestamp_monotonic should probably be a bool rather than an int.
Ok, will change that. Also just realized that the permission could be
0644 isntead of 0600.
> Looks good to me otherwise, as does patch 1.
More information about the dri-devel