[Intel-gfx] [PATCH 2/2] drm/i915: move panel connectors to the front
chris at chris-wilson.co.uk
Sun Oct 28 02:07:06 PDT 2012
On Sat, 27 Oct 2012 15:52:05 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> This essentially reverts
> commit cb0953d734348e8862d6d7edc666cfb3bf6d8fae
> Author: Adam Jackson <ajax at redhat.com>
> Date: Fri Jul 16 14:46:29 2010 -0400
> drm/i915: Initialize LVDS and eDP outputs before anything else
> simply because it doesn't scale: It misses SDVO and DVO panels,
> and now with DDI encoders on haswell this is becoming unmanageable.
> Instead we simply sort the connector list after everything is
> set up.
It's reasonable as any other arrangement. On the other hand, userspace
should understand that the kernel has no policy regarding connector
ordering, which may change on the fly if we ever do hotplug, and do the
sorting itself if it cared about making its legacy clients work better.
The code looks fine so it's a mixture of r-b and a-b.
Chris Wilson, Intel Open Source Technology Centre
More information about the dri-devel