[Bug 54832] Regression: 185ed2105829d6f5eb19edb9abbf0d7977e157c3 breaks swtcl on r300g

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54832

--- Comment #2 from Tom Stellard <tstellar at gmail.com> 2012-09-13 13:26:16 UTC ---
(In reply to comment #1)
> Someone on the mailing list suspects that in r300 compiler is somekind of bug.
> He wrote:
> 
> In playing with Coccinelle, I discovered a signed/unsigned bug in
> radeon_rename_regs.c:rc_rename_regs.
> 
> unsigned new_index;
> unsigned writemask;
> struct rc_variable * var = var_ptr->Item;
> 
> if (var->Inst->U.I.DstReg.File != RC_FILE_TEMPORARY) {
>         continue;
> }
> 
> new_index = rc_find_free_temporary_list(c, used, used_length,
>                                                 RC_MASK_XYZW);
> if (new_index < 0) {
>         rc_error(c, "Ran out of temporary registers\n");
>         return;
> }
> 
> unsigned new_index is compared with < 0.
> 
> I don't know the code, but I can't imagine that you'd need an unsigned
> to represent a register index value.
> 
> Matt Turner

Please file a separate bug for this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.