[PULL] SH Mobile DRM driver for v3.7

[Dave Airlie]

On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> Hi Dave,
>
> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
> requires GEM and KMS/FB helpers that have been reviewed on the list and
> tested. Sascha is waiting for them to reach your tree to send a pull request
> for another new driver.

Just a quick review before I pull,

Why does include/drm/shmob_drm.h exist? this file is meant to define
the userspace API to the driver, if you don't have any userspace API
or driver specific ioctls, this file shouldn't be required. You might
want to create include/drm/shmob_internal.h maybe, if this is used as
an interface to other places in the kernel. I probably need to check
other have been doing the right thing here as well. (driver_drm.h
should be user facing only)

Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
no driver is ever going to want to tweak the drm_fbdev_cma_ops?
really? you are forcing the driver into a corner, drivers call into
helpers, midlayers call into drivers or block them from being called.
you should probably at least change it so the fb_ops are passed into
drm_fbdev_cma_create.

Dave.