[PULL] SH Mobile DRM driver for v3.7

[Dave Airlie]

On Mon, Sep 17, 2012 at 1:38 AM, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> On Saturday 15 September 2012 15:06:13 Lars-Peter Clausen wrote:
>> On 09/15/2012 01:28 AM, Dave Airlie wrote:
>> > On Fri, Sep 14, 2012 at 10:38 PM, Laurent Pinchart wrote:
>> >> Hi Dave,
>> >>
>> >> The SH Mobile DRM driver is now (in my opinion) ready for mainline. It
>> >> requires GEM and KMS/FB helpers that have been reviewed on the list and
>> >> tested. Sascha is waiting for them to reach your tree to send a pull
>> >> request for another new driver.
>> >
>> > Just a quick review before I pull,
>> >
>> > Why does include/drm/shmob_drm.h exist? this file is meant to define
>> > the userspace API to the driver, if you don't have any userspace API
>> > or driver specific ioctls, this file shouldn't be required. You might
>> > want to create include/drm/shmob_internal.h maybe, if this is used as
>> > an interface to other places in the kernel. I probably need to check
>> > other have been doing the right thing here as well. (driver_drm.h
>> > should be user facing only)
>> >
>> > Uggh drm_fb_cma_helper.c is pure midlayer mistake, are you 100% sure
>> > no driver is ever going to want to tweak the drm_fbdev_cma_ops?
>>
>> Obviously we can't, for the same reasons we can't know whether there will
>> ever be a driver which needs to use custom fb_ops. It works fine as it is
>> now for three different drivers. And other drivers making use of the cma
>> buffer helpers are likely to have similar requirements, but if we ever get
>> to a point where a driver needs custom fb_ops it is fairly easy to change
>> it then.
>
> Dave, are you fine with that ? If so I'll submit a new pull request with
> include/drm/shmob_drm.h moved to include/linux/platform_data/shmob_drm.h.
>

Yeah it'll do for now, we'll have to see how many new drivers show up
using these helpers.

Dave.