[PATCH] drm: call connector->dpms(OFF) when disabling

Rob Clark rob.clark at linaro.org
Fri Sep 28 06:06:48 PDT 2012


On Fri, Sep 28, 2012 at 2:52 PM, Alan Cox <alan at lxorguk.ukuu.org.uk> wrote:
> On Fri, 28 Sep 2012 09:27:18 +0200
> Rob Clark <rob.clark at linaro.org> wrote:
>
>> From: Rob Clark <rob at ti.com>
>>
>> When disabling unused connectors, be sure to call connector->dpms(OFF),
>> so if there is actually some IP to turn off (such as external bridge
>> chips, etc), these actually do get turned off.
>
> That's a fairly drastic and non-obvious API change for all the other
> drivers. Have you tested this widely on other hardware ?

no, not yet..  just testing the waters to see how much others freak
out first ;-)

But since we disconnect the encoder first, drm_helper_connector_dpms()
should end up being a no-op so I don't think it works out to be quite
as drastic as it sounds.

BR,
-R

> Alan
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list