[PATCH] drm/i915: no lvds quirk for hp t5740
Daniel Vetter
daniel at ffwll.ch
Fri Apr 12 01:39:31 PDT 2013
On Fri, Apr 12, 2013 at 9:23 AM, Ben Mesman (Bossers & Cnossen BV)
<ben at bnc.nl> wrote:
> Hi,
>
> Last year, a patch was made for the "HP t5740e Thin Client" (see http://lists.freedesktop.org/archives/dri-devel/2012-May/023245.html). This device reports an lvds panel, but does not really have one.
>
> The predecessor of this device is the "hp t5740", which also does not have an lvds panel. This patch will add the same quirk for this device. The dmidecode output is attached below the patch.
Diff is ok, but can you please resubmit this as a proper kernel patch
submission? s-o-b is missing and the mail isn't in the usual patch
layout (git format-patch and git send-email highly recommend). But
please keep your intro here as a commit message, it's good ;-) See
Documentation/SubmittingPatches for details
Thanks, Daniel
>
> Regards,
> Ben Mesman.
>
> ===
>
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -748,6 +748,14 @@
> },
> {
> .callback = intel_no_lvds_dmi_callback,
> + .ident = "Hewlett-Packard hp t5740",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "hp t5740"),
> + },
> + },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> .ident = "Hewlett-Packard HP t5740e Thin Client",
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
>
> ===
>
> # dmidecode 2.11
> SMBIOS 2.6 present.
> 43 structures occupying 1552 bytes.
> Table at 0x000FD100.
>
> Handle 0x0000, DMI type 0, 24 bytes
> BIOS Information
> Vendor: American Megatrends Inc.
> Version: 786R8 v1.04
> Release Date: 03/22/2011
> Address: 0xE0000
> Runtime Size: 128 kB
> ROM Size: 1024 kB
> Characteristics:
> PCI is supported
> PNP is supported
> BIOS is upgradeable
> BIOS shadowing is allowed
> ESCD support is available
> Boot from CD is supported
> Selectable boot is supported
> EDD is supported
> 5.25"/360 kB floppy services are supported (int 13h)
> 5.25"/1.2 MB floppy services are supported (int 13h)
> 3.5"/720 kB floppy services are supported (int 13h)
> 3.5"/2.88 MB floppy services are supported (int 13h)
> Print screen service is supported (int 5h)
> 8042 keyboard services are supported (int 9h)
> Serial services are supported (int 14h)
> Printer services are supported (int 17h)
> CGA/mono video services are supported (int 10h)
> ACPI is supported
> USB legacy is supported
> LS-120 boot is supported
> ATAPI Zip drive boot is supported
> BIOS boot specification is supported
> Function key-initiated network boot is supported
> Targeted content distribution is supported
> BIOS Revision: 8.15
>
> Handle 0x0001, DMI type 1, 27 bytes
> System Information
> Manufacturer: Hewlett-Packard
> Product Name: hp t5740
> Version:
> Serial Number: CNVA190LKX
> UUID: 007F6E00-0BBF-E111-83A5-D5B139101A00
> Wake-up Type: Power Switch
> SKU Number: Climbers
> Family: 103C_53302C
>
> Handle 0x0002, DMI type 2, 15 bytes
> Base Board Information
> Manufacturer: Hewlett-Packard
> Product Name: 3641h
> Version:
> Serial Number: CNVA190LKX
> Asset Tag: Climbers
> Features:
> Board is a hosting board
> Board is replaceable
> Location In Chassis: Climbers
> Chassis Handle: 0x0003
> Type: Motherboard
> Contained Object Handles: 0
>
> Handle 0x0003, DMI type 3, 21 bytes
> Chassis Information
> Manufacturer: Hewlett-Packard
> Type: Desktop
> Lock: Not Present
> Version:
> Serial Number: CNVA190LKX
> Asset Tag: <BAD INDEX>
> Boot-up State: Safe
> Power Supply State: Safe
> Thermal State: Safe
> Security Status: None
> OEM Information: 0x00000000
> Height: Unspecified
> Number Of Power Cords: 1
> Contained Elements: 0
>
> Handle 0x0004, DMI type 4, 42 bytes
> Processor Information
> Socket Designation: CPU 1
> Type: Central Processor
> Family: Other
> Manufacturer: Intel
> ID: C2 06 01 00 FF FB E9 BF
> Version: Intel(R) Atom(TM) CPU N280 @ 1.66GHz
> Voltage: 1.2 V
> External Clock: 167 MHz
> Max Speed: 1666 MHz
> Current Speed: 1666 MHz
> Status: Populated, Enabled
> Upgrade: None
> L1 Cache Handle: 0x0005
> L2 Cache Handle: 0x0006
> L3 Cache Handle: Not Provided
> Serial Number: To Be Filled By O.E.M.
> Asset Tag: To Be Filled By O.E.M.
> Part Number: To Be Filled By O.E.M.
> Core Count: 1
> Core Enabled: 1
> Thread Count: 2
> Characteristics: None
>
> Handle 0x0005, DMI type 7, 19 bytes
> Cache Information
> Socket Designation: L1-Cache
> Configuration: Enabled, Not Socketed, Level 1
> Operational Mode: Write Back
> Location: Internal
> Installed Size: 24 kB
> Maximum Size: 24 kB
> Supported SRAM Types:
> Burst
> Installed SRAM Type: Burst
> Speed: Unknown
> Error Correction Type: Unknown
> System Type: Data
> Associativity: Other
>
> Handle 0x0006, DMI type 7, 19 bytes
> Cache Information
> Socket Designation: L2-Cache
> Configuration: Enabled, Not Socketed, Level 2
> Operational Mode: Write Back
> Location: Internal
> Installed Size: 512 kB
> Maximum Size: 512 kB
> Supported SRAM Types:
> Burst
> Installed SRAM Type: Burst
> Speed: Unknown
> Error Correction Type: Unknown
> System Type: Unified
> Associativity: 8-way Set-associative
>
> Handle 0x0007, DMI type 5, 20 bytes
> Memory Controller Information
> Error Detecting Method: None
> Error Correcting Capabilities:
> None
> Supported Interleave: One-way Interleave
> Current Interleave: One-way Interleave
> Maximum Memory Module Size: 4096 MB
> Maximum Total Memory Size: 8192 MB
> Supported Speeds:
> Other
> Supported Memory Types:
> SIMM
> SDRAM
> Memory Module Voltage: 3.3 V
> Associated Memory Slots: 2
> 0x0008
> 0x0009
> Enabled Error Correcting Capabilities:
> None
>
> Handle 0x0008, DMI type 6, 12 bytes
> Memory Module Information
> Socket Designation: DIMM0
> Bank Connections: 0 1
> Current Speed: Unknown
> Type: DIMM SDRAM
> Installed Size: 1024 MB (Single-bank Connection)
> Enabled Size: 1024 MB (Single-bank Connection)
> Error Status: OK
>
> Handle 0x0009, DMI type 6, 12 bytes
> Memory Module Information
> Socket Designation: DIMM1
> Bank Connections: 4 5
> Current Speed: Unknown
> Type: DIMM SDRAM
> Installed Size: Not Installed
> Enabled Size: Not Installed
> Error Status: OK
>
> Handle 0x000A, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: COM1
> Internal Connector Type: 9 Pin Dual Inline (pin 10 cut)
> External Reference Designator: COM A
> External Connector Type: DB-9 male
> Port Type: Serial Port 16450 Compatible
>
> Handle 0x000B, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: COM2
> Internal Connector Type: 9 Pin Dual Inline (pin 10 cut)
> External Reference Designator: COM B
> External Connector Type: DB-9 male
> Port Type: Serial Port 16450 Compatible
>
> Handle 0x000C, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: LPT1
> Internal Connector Type: DB-25 female
> External Reference Designator: PARALLEL
> External Connector Type: DB-25 female
> Port Type: Parallel Port ECP/EPP
>
> Handle 0x000D, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB0
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x000E, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB1
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x000F, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB2
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0010, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB3
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0011, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB4
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0012, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB5
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0013, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB6
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0014, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: USB7
> External Connector Type: Access Bus (USB)
> Port Type: USB
>
> Handle 0x0015, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: LAN
> External Connector Type: RJ-45
> Port Type: Network Port
>
> Handle 0x0016, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: VGA
> External Connector Type: DB-15 female
> Port Type: Video Port
>
> Handle 0x0017, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: Line out
> External Connector Type: Mini Jack (headphones)
> Port Type: Audio Port
>
> Handle 0x0018, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: Microphone
> External Connector Type: Mini Jack (headphones)
> Port Type: Audio Port
>
> Handle 0x0019, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: Keyboard
> External Connector Type: PS/2
> Port Type: Keyboard Port
>
> Handle 0x001A, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: Null
> Internal Connector Type: None
> External Reference Designator: Mouse
> External Connector Type: PS/2
> Port Type: Mouse Port
>
> Handle 0x001B, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: PRIMARY IDE
> Internal Connector Type: On Board IDE
> External Reference Designator: Not Specified
> External Connector Type: None
> Port Type: Other
>
> Handle 0x001C, DMI type 8, 9 bytes
> Port Connector Information
> Internal Reference Designator: SECONDARY IDE
> Internal Connector Type: On Board IDE
> External Reference Designator: Not Specified
> External Connector Type: None
> Port Type: Other
>
> Handle 0x001D, DMI type 9, 17 bytes
> System Slot Information
> Designation: PCI-X
> Type: 32-bit PCI-X
> Current Usage: Available
> Length: Long
> ID: 0
> Characteristics:
> 5.0 V is provided
> PME signal is supported
>
> Handle 0x001E, DMI type 11, 5 bytes
> OEM Strings
> String 1: $OSTYPE11001
> String 2: $582271-00100WES
>
> Handle 0x001F, DMI type 13, 22 bytes
> BIOS Language Information
> Language Description Format: Long
> Installable Languages: 3
> en|US|iso8859-1
> es|ES|iso8859-1
> de|DE|iso8859-1
> Currently Installed Language: en|US|iso8859-1
>
> Handle 0x0020, DMI type 16, 15 bytes
> Physical Memory Array
> Location: System Board Or Motherboard
> Use: System Memory
> Error Correction Type: None
> Maximum Capacity: 8 GB
> Error Information Handle: Not Provided
> Number Of Devices: 2
>
> Handle 0x0021, DMI type 19, 15 bytes
> Memory Array Mapped Address
> Starting Address: 0x00000000000
> Ending Address: 0x0003FFFFFFF
> Range Size: 1 GB
> Physical Array Handle: 0x0020
> Partition Width: 4
>
> Handle 0x0022, DMI type 17, 28 bytes
> Memory Device
> Array Handle: 0x0020
> Error Information Handle: Not Provided
> Total Width: 64 bits
> Data Width: 64 bits
> Size: 1024 MB
> Form Factor: SODIMM
> Set: None
> Locator: DIMM0
> Bank Locator: BANK0
> Type: DDR2
> Type Detail: Synchronous
> Speed: Unknown
> Manufacturer: Samsung
> Serial Number: 27E07E66
> Asset Tag: AssetTagNum0
> Part Number: M471B2873EH1-CH9
> Rank: 14
>
> Handle 0x0023, DMI type 20, 19 bytes
> Memory Device Mapped Address
> Starting Address: 0x00000000000
> Ending Address: 0x0003FFFFFFF
> Range Size: 1 GB
> Physical Device Handle: 0x0022
> Memory Array Mapped Address Handle: 0x0021
> Partition Row Position: 1
>
> Handle 0x0024, DMI type 17, 28 bytes
> Memory Device
> Array Handle: 0x0020
> Error Information Handle: Not Provided
> Total Width: Unknown
> Data Width: 64 bits
> Size: No Module Installed
> Form Factor: SODIMM
> Set: None
> Locator: DIMM1
> Bank Locator: BANK1
> Type: Unknown
> Type Detail: Unknown
> Speed: Unknown
> Manufacturer: Manufacturer01
> Serial Number: SerNum01
> Asset Tag: AssetTagNum1
> Part Number: ModulePartNumber01
> Rank: Unknown
>
> Handle 0x0025, DMI type 20, 19 bytes
> Memory Device Mapped Address
> Starting Address: 0x00000000000
> Ending Address: 0x000000003FF
> Range Size: 1 kB
> Physical Device Handle: 0x0024
> Memory Array Mapped Address Handle: 0x0021
> Partition Row Position: 1
>
> Handle 0x0026, DMI type 16, 15 bytes
> Physical Memory Array
> Location: System Board Or Motherboard
> Use: Flash Memory
> Error Correction Type: None
> Maximum Capacity: 1 MB
> Error Information Handle: Not Provided
> Number Of Devices: 1
>
> Handle 0x0027, DMI type 19, 15 bytes
> Memory Array Mapped Address
> Starting Address: 0x000FFF00000
> Ending Address: 0x000FFFFFFFF
> Range Size: 1 MB
> Physical Array Handle: 0x0026
> Partition Width: 1
>
> Handle 0x0028, DMI type 17, 28 bytes
> Memory Device
> Array Handle: 0x0026
> Error Information Handle: Not Provided
> Total Width: 8 bits
> Data Width: 8 bits
> Size: 1024 kB
> Form Factor: Chip
> Set: None
> Locator: U24
> Bank Locator:
> Type: Flash
> Type Detail: Non-Volatile
> Speed: 33 MHz
> Manufacturer: MXIC
> Serial Number:
> Asset Tag:
> Part Number: 25L8005
> Rank: Unknown
>
> Handle 0x0029, DMI type 20, 19 bytes
> Memory Device Mapped Address
> Starting Address: 0x000FFF00000
> Ending Address: 0x000FFFFFFFF
> Range Size: 1 MB
> Physical Device Handle: 0x0028
> Memory Array Mapped Address Handle: 0x0027
> Partition Row Position: 1
>
> Handle 0x002A, DMI type 127, 4 bytes
> End Of Table
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dri-devel
mailing list